pybamm-team / PyBaMM

Fast and flexible physics-based battery models in Python
https://www.pybamm.org/
BSD 3-Clause "New" or "Revised" License
1.12k stars 547 forks source link

Make ParameterValues.pop return a value #4571

Closed kratman closed 2 weeks ago

kratman commented 2 weeks ago

Description

Quick fix to make pop() return a value

Fixes #4569

Type of change

Key checklist:

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.29%. Comparing base (4a50562) to head (04d70b1). Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #4571 +/- ## ======================================== Coverage 99.29% 99.29% ======================================== Files 300 300 Lines 22776 22776 ======================================== Hits 22615 22615 Misses 161 161 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.