pybamm-team / PyBaMM

Fast and flexible physics-based battery models in Python
https://www.pybamm.org/
BSD 3-Clause "New" or "Revised" License
1.12k stars 547 forks source link

Update baseline for CasADi 3.6.7 bump #4582

Closed agriyakhetarpal closed 1 week ago

agriyakhetarpal commented 1 week ago

Description

I updated https://github.com/pybamm-team/casadi-vcpkg-registry/ to build CasADi 3.6.7, and this PR updates the baseline to account for that change – so that we build our extension module against CasADi 3.6.7.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

Key checklist:

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

agriyakhetarpal commented 1 week ago

Triggered a build from this branch on my fork here: https://github.com/agriyakhetarpal/PyBaMM/actions/runs/11805727556. If this passes, we should be good to go. I've marked it as a draft until then.

@kratman, this should be included in the release

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.26%. Comparing base (cb50363) to head (69a70f7). Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #4582 +/- ## ======================================== Coverage 99.26% 99.26% ======================================== Files 302 302 Lines 22889 22889 ======================================== Hits 22721 22721 Misses 168 168 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

agriyakhetarpal commented 1 week ago

The Windows build and tests are passing, but I'm unsure (and haven't followed along) what's up with the Linux wheels – it looks like the solver crashes at runtime. https://github.com/agriyakhetarpal/PyBaMM/actions/runs/11805727556/job/32890103930. That failure is unrelated to this change, though.

kratman commented 1 week ago

The Windows build and tests are passing, but I'm unsure (and haven't followed along) what's up with the Linux wheels – it looks like the solver crashes at runtime. https://github.com/agriyakhetarpal/PyBaMM/actions/runs/11805727556/job/32890103930. That failure is unrelated to this change, though.

I triggered the same changes on my pybammsolvers repo to see if I get the same failures

agriyakhetarpal commented 1 week ago

Looks like it's coming from here:

https://github.com/pybamm-team/PyBaMM/blob/cb503633c7c920c4d78d4ad62c60091539188ad4/src/pybamm/config.py#L84-L97

kratman commented 1 week ago

Looks like it's coming from here

Are you working on that one here, or should I start working on it so that it does not block the release

agriyakhetarpal commented 1 week ago

Looks like it's coming from here

Are you working on that one here, or should I start working on it so that it does not block the release

Yes, I'm looking into it as we speak and I have a fix, but I'll test it in CI first and check if it works.

kratman commented 1 week ago

Since the crash is unrelated, is anything left on this one?

agriyakhetarpal commented 1 week ago

Nothing else, this is ready to go