pybamm-team / PyBaMM

Fast and flexible physics-based battery models in Python
https://www.pybamm.org/
BSD 3-Clause "New" or "Revised" License
1.12k stars 547 forks source link

Remove IREE solver #4585

Open kratman opened 1 week ago

kratman commented 1 week ago

Description

Removes the IREE solver. The IREE solver only supports single precision and is difficult to update. It might be re-added in the future when it is more stable.

Fixes #4521

Key checklist:

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

kratman commented 1 week ago

I am expecting some stuff to fail and for this branch to require additional changes

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.20%. Comparing base (cb50363) to head (5670fb0). Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #4585 +/- ## =========================================== - Coverage 99.26% 99.20% -0.06% =========================================== Files 302 302 Lines 22889 22705 -184 =========================================== - Hits 22721 22525 -196 - Misses 168 180 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kratman commented 1 week ago

@jsbrittain Can you look at this too please?