pybamm-team / PyBaMM

Fast and flexible physics-based battery models in Python
https://www.pybamm.org/
BSD 3-Clause "New" or "Revised" License
1.12k stars 548 forks source link

Fix telemetry issues in wheel build and unit tests #4591

Closed kratman closed 1 week ago

kratman commented 1 week ago

Description

Fixes the wheel build and updates the telemetry code to make sure it does not run during tests

Fixes #4588

Type of change

Key checklist:

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.25%. Comparing base (bcdd0b5) to head (f31fae1). Report is 4 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #4591 +/- ## =========================================== - Coverage 99.26% 99.25% -0.02% =========================================== Files 302 302 Lines 22889 22906 +17 =========================================== + Hits 22721 22735 +14 - Misses 168 171 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

kratman commented 1 week ago

Coverage is easy to fix. I will do that before I mark it ready for review

kratman commented 1 week ago

Wheel build passed, this should be ready for the release