pybamm-team / liionpack

A battery pack simulation tool that uses the PyBaMM framework
https://liionpack.readthedocs.io/en/latest/
MIT License
84 stars 26 forks source link

Add ability to do voltage and power control from experiments #174

Open Jadhav-Sourabh opened 2 years ago

Jadhav-Sourabh commented 2 years ago

liionpack Version

0.3.2

Python Version

3.8

Describe the bug

Why this is not possible? "Charge at 1C until 4.2V", "Hold at 4.2V until C/20"

Steps to Reproduce

No response

Expected behaviour

No response

Relevant log output

No response

Additional context

No response

wigging commented 2 years ago

I think the upper and lower cutoff voltage is 4.2 volts. Try your experiment with 4.1 V or lower.

Jadhav-Sourabh commented 2 years ago

But 4.2V is working finely in pybamm

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: Gavin Wiggins @.> Sent: Thursday, July 28, 2022 7:10:46 PM To: pybamm-team/liionpack @.> Cc: Sourabh Jadhav @.>; Author @.> Subject: Re: [pybamm-team/liionpack] Experiment[Bug]: (Issue #174)

I think the upper and lower cutoff voltage is 4.2 volts. Try your experiment with 4.1 V or lower.

— Reply to this email directly, view it on GitHubhttps://github.com/pybamm-team/liionpack/issues/174#issuecomment-1198158350, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AU7LVHRVDMW2SWWFL466YILVWKEV5ANCNFSM543634MQ. You are receiving this because you authored the thread.Message ID: @.***>

wigging commented 2 years ago

In liionpack voltage limits are checked as shown below. So if your experiment exceeds these voltage limits then it will exit the simulation or at least show a warning.

https://github.com/pybamm-team/liionpack/blob/306ef75e2f20bd86ff8541db065e7175ff1a8b1a/liionpack/solvers.py#L441-L448

Jadhav-Sourabh commented 2 years ago

In liionpack voltage limits are checked as shown below. So if your experiment exceeds these voltage limits then it will exit the simulation or at least show a warning.

https://github.com/pybamm-team/liionpack/blob/306ef75e2f20bd86ff8541db065e7175ff1a8b1a/liionpack/solvers.py#L441-L448

a1 a2 a3

Jadhav-Sourabh commented 2 years ago

In liionpack voltage limits are checked as shown below. So if your experiment exceeds these voltage limits then it will exit the simulation or at least show a warning. https://github.com/pybamm-team/liionpack/blob/306ef75e2f20bd86ff8541db065e7175ff1a8b1a/liionpack/solvers.py#L441-L448

a1 a2 a3

I want to implement CCCV in liionpack. I already implemented successfully CCCV in pybamm

TomTranter commented 2 years ago

Apologies for not checking these issues regularly. I need to sort out my github notifications. As discussed on the PyBaMM discussion this functionality needs to be added. Liionpack only works for CC and drive cycles not voltage or power driven experiments. Just FYI this will probably be quite a significant development and is not a high priority for me right now

wigging commented 2 years ago

@Sourabh-Jadhav-2 GitHub supports syntax highlighted code blocks. See the links below for more information. There's no need to take screenshots of code or terminal output.

https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#quoting-code

https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-and-highlighting-code-blocks

philgravy commented 1 month ago

Were you ever able to resolve the issue? I'm experiencing the same problem