search

pybamm-team / liionpack

A battery pack simulation tool that uses the PyBaMM framework
https://liionpack.readthedocs.io/en/latest/
MIT License
90 stars 30 forks source link

Test only on pybamm stable #229

Closed Saransh-cpp closed 1 year ago

Saransh-cpp commented 1 year ago

This is failing as expected. This should be ready to merge when a new version of PyBaMM is released. After this is merged, it would be safe to delete the main branch as our primary branch will now be develop.

One more comment, you will have to update the version pin of pybamm if the new release of liionpack will not be compatible with the older pybamm versions.

TomTranter commented 1 year ago

Thanks alot for you help on this @Saransh-cpp. I figured out how to activate pre-commit on the other PR

Saransh-cpp commented 1 year ago

Great! I'll get this up!

codecov[bot] commented 1 year ago

Codecov Report

Merging #229 (3d0700c) into develop (0eae90e) will not change coverage. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #229 +/- ## ======================================== Coverage 94.78% 94.78% ======================================== Files 11 11 Lines 1188 1188 ======================================== Hits 1126 1126 Misses 62 62 ```
Saransh-cpp commented 1 year ago

@TomTranter this looks good now. Everything will now shift only to the develop branch, every release must be made through develop, and every PR should go into develop. This also means that we will only test on the stable version of PyBaMM. Everything is passing right now, but whenever you make some changes to support a new breaking release of PyBaMM, you must bump the PyBaMM required version in pyproject.toml.

rtimms commented 1 year ago

thanks @Saransh-cpp ! IMO we should pin a PyBaMM version since the liionpack dev cycle is slower. My preference would be to pin to 23.3 for now since there were a lot of changes (in particular dimensional models), fix bugs and make a liionpack release.

Then we can take a step back and plan out the next steps (integrate into PyBaMM or keep it separate).