This test fails as liionpack creates 21 time points and pybamm 22. The difference is around the transition where pybamm repeats the step at 10 s for the new experiment (ie includes a zero'th entry for cycle 2) and lp doesn't. Liionpack doesn't do any re-initialisation of solutions and fixes time steps at solve. This isn't ideal but it's not a major problem either and would eventually be fixed by merging solver routines into PyBaMM
liionpack Version
0.3.3
Python Version
23.2
Describe the bug
https://github.com/pybamm-team/liionpack/blob/37ebc63803469fc709747da0249bfce2aa74a75c/tests/integration/test_1p1s.py#L40
This test fails as liionpack creates 21 time points and pybamm 22. The difference is around the transition where pybamm repeats the step at 10 s for the new experiment (ie includes a zero'th entry for cycle 2) and lp doesn't. Liionpack doesn't do any re-initialisation of solutions and fixes time steps at solve. This isn't ideal but it's not a major problem either and would eventually be fixed by merging solver routines into PyBaMM
Steps to Reproduce
No response
Expected behaviour
No response
Relevant log output
No response
Additional context
No response