search

pybamm-team / liionpack

A battery pack simulation tool that uses the PyBaMM framework
https://liionpack.readthedocs.io/en/latest/
MIT License
83 stars 26 forks source link

Fix issue 258 #259

Closed TomTranter closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #259 (27e3358) into develop (8a5d668) will not change coverage. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #259 +/- ## ======================================== Coverage 94.78% 94.78% ======================================== Files 11 11 Lines 1188 1188 ======================================== Hits 1126 1126 Misses 62 62 ```
TomTranter commented 1 year ago

@srikanthallu are you referring to documenting the plan to merge solving into PyBaMM or this specific bug fix. I normally update the changelog before merging develop into main but is probably good practice to update it on each PR if that's what you mean. Thanks

srikanthallu commented 1 year ago

Yes @TomTranter , I was referring to updating the changelog in this PR.