search

pybamm-team / liionpack

A battery pack simulation tool that uses the PyBaMM framework
https://liionpack.readthedocs.io/en/latest/
MIT License
83 stars 26 forks source link

Model Events & Model Names Haulting Code Execution #284

Closed mleot closed 4 months ago

mleot commented 5 months ago

I am creating this PR to try and fix the issue I was having when liionpack detected cells hitting the voltage cutoff. This happens when I am using JellyBaMM to run simulations, where the thermal_external simulation type is used.

The model events and model events names have a different length leading to the error described in issue #282.

The commit I have already added is just in place to prevent the code execution from haulting, but is not a fix to prevent the issue from occuring.

mleot commented 5 months ago

@TomTranter This a related issue to JellyBaMM, but lives in the liionpack repo. I forgot to assign a reviewer when I opened the PR, so I am tagging you now.

TomTranter commented 4 months ago

@mleot I had a look at this PR and it seemed to have a lot of changes to notebooks that were unrelated so I made a new one with just the update to solver_utils #288

TomTranter commented 4 months ago

I also removed jax as this was causing some errors with the ci