pybamm-team / liionpack

A battery pack simulation tool that uses the PyBaMM framework
https://liionpack.readthedocs.io/en/latest/
MIT License
83 stars 26 forks source link

Pass protocol instead of experiment to solvers #291

Closed TomTranter closed 4 months ago

TomTranter commented 4 months ago

Description

Not every PyBaMM experiment step will work with liionpack which only supports current based control and also does not have all the termination conditions. It would be better to convert an experiment explicitly whilst giving warnings of these limitations and then pass the protocol to the solver instead of having certain features not work or missing. Relates to #290

Motivation

No response

Possible Implementation

No response

Additional context

No response