search

pybamm-team / liionpack

A battery pack simulation tool that uses the PyBaMM framework
https://liionpack.readthedocs.io/en/latest/
MIT License
90 stars 30 forks source link

[Bug]: Only Current Operations are Supported #317

Open philgravy opened 3 months ago

philgravy commented 3 months ago

liionpack Version

Latest

Python Version

3.12.4

Describe the bug

Experiments ran with Liionpack seem to not have the same capabilities as PyBaMM. Running experiments such as "Charge at 1 C until 4.1 V" are met with the error "Only Current Operations are Supported", meaning that experiments can only be ran with current and nothing more. If I'm simply trying to charge a battery from 0% to 100%, how can I do so with Liionpack if lithium ion batteries charge using CC/CV charging? I'm open to modifying source code, but I'd appreciate some direction with this endeavor. Thanks

Steps to Reproduce

Attempt running an experiment that involved voltage or C-rate, such as "Charge at 1C until 4.1 V"

Expected behaviour

Fully charging a battery

Relevant log output

31 termination = step.termination
     32 if typ not in ["current", "power"]:
---> 33     raise ValueError("Only current operations are supported")
     34 else:
     35     if not step.is_drive_cycle:

ValueError: Only current operations are supported

Additional context

No response