Closed arjxn-py closed 2 months ago
Docs are building here : https://pybamm-eis.readthedocs.io/en/latest/ Prettification remains.
awesome, thanks! just need to fix conflicts with the optional dependencies (literally merged #12 just as this opened)
let's merge this and worry about making it pretty later. can you also update the readme to point to the docs?
awesome, thanks! just need to fix conflicts with the optional dependencies (literally merged #12 just as this opened)
let's merge this and worry about making it pretty later. can you also update the readme to point to the docs?
Thanks for adding the tests @rtimms, so sorry that it took me more time than expected.
I've resolved the dependency conflicts, in addition to that we also have to note that currently readthedocs
is building from my fork's arjxn-py:10-host-readthedocs
branch so I'd update hosting too on readthedocs so that it builds from the main branch of upstream once this is merged (as .readthedocs.yaml
was required to build so I just chose my fork for testing)
great, thanks, @arjxn-py !
Hosts documentation on
readthedocs
. Should fix #10