search

pybamm-team / pybamm-eis

https://pybamm-eis.readthedocs.io/
MIT License
12 stars 2 forks source link

Semi-circle for the SPMe #18

Closed noelhallemans closed 3 months ago

noelhallemans commented 3 months ago

Hi,

Comparing EIS data of different models in compare_models.py, it appears that the SPMe does not have a semi-circle for the same electrode double-layer capacity as the other models.

options={"surface form": "differential"} and both positive and negative electrode double-layer capacities are set to 0.2 F m-2 for the figure below

Screenshot 2024-07-12 at 14 31 47

This is unexpected as the semi-circles of all models should be quite similar!

Interestingly, semi-circles for the SPMe appear when choosing the electrode double-layer capacity values unreasonably high:

100 F/m2: image

compared to 0.2 F/m2: Screenshot 2024-07-12 at 14 38 43

This may be related to the bug in leading surface form conductivity (https://github.com/pybamm-team/PyBaMM/pull/4139), however, using the develop branch does not solve this issue.

We use PyBAMM version 24.1.

Kind regards,

Noël

rtimms commented 3 months ago

will be fixed by https://github.com/pybamm-team/PyBaMM/pull/4293