pybamm-team / pybamm-eis

https://pybamm-eis.readthedocs.io/
MIT License
11 stars 2 forks source link

Hard coded reaction rate and electrode charge transfer coefficients #22

Open noelhallemans opened 1 month ago

noelhallemans commented 1 month ago

The reaction rate and electrode charge transfer coefficient parameters are hard coded in the exchange current density function (through the Butler-Volmer kinetics). I believe these are parameters that vary from battery to battery.

Wouldn't it make more sense to also consider these parameters in the parameter set? This would help for model parametrisation from impedance data as the reaction rate parameter could then represent the charge transfer resistance in a model where parameters are grouped.

rtimms commented 1 month ago

You can define them as Parameter objects inside the function, see this example