search

pybamm-team / pybamm.org

Source code for pybamm.org
https://www.pybamm.org/
BSD 3-Clause "New" or "Revised" License
7 stars 6 forks source link

Added GitHub Link #174

Closed Bashamega closed 3 months ago

Bashamega commented 3 months ago

closes #171

netlify[bot] commented 3 months ago

Deploy Preview for pybamm-developer-preview ready!

Name Link
Latest commit c99a4e218164a56ce831e938b4f4df40269148f4
Latest deploy log https://app.netlify.com/sites/pybamm-developer-preview/deploys/66b4b116a954ba000816e1cc
Deploy Preview https://deploy-preview-174--pybamm-developer-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Bashamega commented 3 months ago

Sorry, they i thought they said the org

arjxn-py commented 3 months ago

Sorry, they i thought they said the org

No worries, thanks for fixing :) Lastly I just want to confirm if you're also looking into getting badges on index page too so that we can wait for you & if not just let me know and I'll be happy to approve then.

Bashamega commented 3 months ago

Sorry, they i thought they said the org

No worries, thanks for fixing :) Lastly I just want to confirm if you're also looking into getting badges on index page too so that we can wait for you & if not just let me know and I'll be happy to approve then.

Sure, I will try to complete it

Bashamega commented 3 months ago

Hello @arjxn-py . I re-read @agriyakhetarpal and he said that it will be added in #172 . Do you still want me to do it?

arjxn-py commented 3 months ago

I guess he meant that we can add those badges after the changes in #172, I think we would have to wait for #172 to get in first and then rebase this branch.

Bashamega commented 3 months ago

I guess he meant that we can add those badges after the changes in #172, I think we would have to wait for #172 to get in first and then rebase this branch.

I can easily add it. If you want

Bashamega commented 3 months ago

I have added the badge

Bashamega commented 3 months ago

Thanks @Bashamega, nice work. I'd like the badges better in a single row. And alignment is a bit off when aligned left, center align should be better.

On my view it is on one row. I don't know how to center it. Can you commit it?