search

pybamm-team / pybamm.org

Source code for pybamm.org
https://www.pybamm.org/
BSD 3-Clause "New" or "Revised" License
7 stars 6 forks source link

Added Santhosh Sundaram's final GSoC report #182

Closed santacodes closed 2 months ago

santacodes commented 2 months ago

This is my submission for the GSoC 2024 final report on my project pybamm-cookie.

netlify[bot] commented 2 months ago

Deploy Preview for pybamm-developer-preview ready!

Name Link
Latest commit 4bec9f295ee07904e76ed62010b74085e0c0008e
Latest deploy log https://app.netlify.com/sites/pybamm-developer-preview/deploys/66cc94cccc124b00083c241e
Deploy Preview https://deploy-preview-182--pybamm-developer-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

agriyakhetarpal commented 2 months ago

Thanks, @santacodes! Please confirm if this is ready for merging?

agriyakhetarpal commented 2 months ago

After this, could you open a separate PR to add a link to it to https://pybamm.org/gsoc/#project-reports?

santacodes commented 2 months ago

Thanks, @santacodes! Please confirm if this is ready for merging?

Yeah, I think so, I have checked the contents from my side but if you see anything wrong feel free to point it out! Or else it is good to merge. Thanks :)

santacodes commented 2 months ago

After this, could you open a separate PR to add a link to it to https://pybamm.org/gsoc/#project-reports?

Sure!

arjxn-py commented 2 months ago

After this, could you open a separate PR to add a link to it to https://pybamm.org/gsoc/#project-reports?

How about we do it in the same PR, I think we may anticipate the report url before this PR gets merged?

agriyakhetarpal commented 2 months ago

I just wanted to preserve linear history by squashing the PR

arjxn-py commented 2 months ago

I just wanted to preserve linear history by squashing the PR

I see, sounds good to me then