pybind / pybind11

Seamless operability between C++11 and Python
https://pybind11.readthedocs.io/
Other
15.18k stars 2.06k forks source link

fix(cmake): make library component optional #4805

Closed henryiii closed 8 months ago

henryiii commented 11 months ago

Description

This fixes a probably long standing bug where set(PYBIND11_FINDPYTHON ON) couldn't be used in manylinux. Fix #4802.

Suggested changelog entry:

* Don't require the libs component on CMake 3.18+ when using PYBIND11_FINDPYTHON (fixes manylinux builds).
wjakob commented 8 months ago

LGTM, nice catch!