Closed sizmailov closed 10 months ago
@rwgk Is it better now?
Yes, thanks, looks great! The only thing I'd still change is the changelog entry, maybe:
Builtins collections names in docstrings are now consistently rendered in lowercase (list
, set
, dict
, tuple
), in accordance with PEP 585.
@rwgk I've updated the changelog entry. Thanks for the suggestion.
This feels like it warrants a version bump as it will break docstring unit tests.
This feels like it warrants a version bump
That was my assumption (pybind11 v2.12). We already have an internals version bump for MSVC on master.
as it will break docstring unit tests.
Could you please explain more? I'm not sure.
Description
The #4259 introduced lowercase annotations for collections (e.g.
list
forpybind::typing::List
), while the other parts of thepybind11
still use uppercase annotations for the same python types. This might lead to a mix of upper/lower case for collections:This PR fixes this inconsistency, rendering all collection types in lowercase according to PEP 585.
Note: The change is NOT incompatible with Python 3.6, since it alters only docstrings.
Fixes #4828
Suggested changelog entry: