search

pybind / pybind11

Seamless operability between C++11 and Python
https://pybind11.readthedocs.io/
Other
15.09k stars 2.05k forks source link

ci: skipping test for Windows Clang failure #5062

Closed henryiii closed 3 months ago

henryiii commented 3 months ago

Description

Skipping a test for a Clang failure. Also hiding a warning in Clang that we hide in GCC.

Last successful log: 2024-02-20T21:40:01.6656694Z https://github.com/pybind/pybind11/actions/runs/7980348964/job/21789806071

First failing log: 2024-02-27T17:04:02.7790106Z https://github.com/pybind/pybind11/actions/runs/8067833464/job/22041600407

The log files are permanently archived here: https://github.com/rwgk/issues/tree/master/pybind11/pr_5062

henryiii commented 3 months ago

pybind11_tests.compiler_info.startswith('Homebrew Clang') is this ever True? To me it looks like it can be msvc version or __version__, and nothing else. Edit: maybe the problem is only that MSVC comes first, and Clang loves to pretend it's MSVC on windows (and GCC on Unix).

rwgk commented 3 months ago

I will make this comment more complete as I get a chance (asap).

Last successful log: 2024-02-20T21:40:01.6656694Z https://github.com/pybind/pybind11/actions/runs/7980348964/job/21789806071

First failing log: 2024-02-27T17:04:02.7790106Z https://github.com/pybind/pybind11/actions/runs/8067833464/job/22041600407