search

pybind / pybind11

Seamless operability between C++11 and Python
https://pybind11.readthedocs.io/
Other
15.08k stars 2.05k forks source link

fix(cmake): old cmake boost bug #5149

Closed henryiii closed 1 month ago

henryiii commented 1 month ago

Description

Fix #5138.

Suggested changelog entry:

- Fix mistake affecting old cmake and old boost
rwgk commented 1 month ago

LGTM — Is there a reasonably easy way to cover this fix with a new test?

henryiii commented 1 month ago

This is for a version of CMake older than I want to support and a version of Boost older than I want to support, so not very motivated to set one up.

rwgk commented 1 month ago

Sounds good!

On Wed, May 29, 2024 at 15:56 Henry Schreiner @.***> wrote:

This is for a version of CMake older than I want to support and a version of Boost older than I want to support, so not very motivated to set one up.

— Reply to this email directly, view it on GitHub https://github.com/pybind/pybind11/pull/5149#issuecomment-2138385911, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFUZAGXE3KD7KAXVYZ4DKLZEZMLJAVCNFSM6AAAAABIPZ4EJWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZYGM4DKOJRGE . You are receiving this because you commented.Message ID: @.***>