A terrible merge accident introduced with pybind/pybind11#5085: PYBIND11_INTERNALS_SH_DEF was accidentally removed from PYBIND11_INTERNALS_ID and PYBIND11_MODULE_LOCAL_ID. — How did this happen? First PR #5084 on master introduced whitespace changes:
Description
This PR fixes two oversights:
PYBIND11_INTERNALS_SH_DEF
was accidentally removed fromPYBIND11_INTERNALS_ID
andPYBIND11_MODULE_LOCAL_ID
. — How did this happen? First PR #5084 on master introduced whitespace changes:Those were incorrectly applied in smart_holder PR #5085:
-DCMAKE_CXX_FLAGS="-DPYBIND11_USE_SMART_HOLDER_AS_DEFAULT"
(manylinux)Validation of both fixes:
ci.yml manylinux:
ci_sh_def.yml manylinux:
Suggested changelog entry: