Closed 8W9aG closed 7 months ago
@chuckx do you have advice?
From my side, with my very limited bazel knowledge: Currently we have a pretty low bar: if you have changes that make pybind11_bazel work for your purposes, I could run some tests, if nothing is broken it'll look good to me.
Optional: If you could add GHA tests for the things you care about, that would be ideal. — Currently we don't have any testing here at all, but we're testing indirectly via pybind11_abseil and pybind11_protobuf.
Made a PR here: https://github.com/pybind/pybind11_bazel/pull/63
As of the v2.11.1.bzl.2 release, pybind11_bazel uses rules_python. I think everything should work far more smoothly with RBE.
When trying to use these rules with an environment containing remote build executions, I get the following issue:
This is when using the following in
WORKSPACE
:It seems that pybind11_bazel forces things to run locally due to
local = 1
in the following piece of code: https://github.com/pybind/pybind11_bazel/blob/c65db0ac44ff3cd790a803e4a804e2cc806cf641/python_configure.bzl#L101I was wondering if there was a reason local was forced here, and if not can I either remove it or add an option to remove this flag?
This commit seems to add the local option: https://github.com/pybind/pybind11_bazel/commit/992381ced716ae12122360b0fbadbc3dda436dbf
Having said that local is always true, so maybe it just needs to be propagated?