Update external dependency retrieval from WORKSPACE to MODULE to support bzlmod

pybind / pybind11_protobuf

Pybind11 bindings for Google's Protocol Buffers

Other

54 stars 33 forks source link

Update external dependency retrieval from WORKSPACE to MODULE to support bzlmod #149

Closed phaedon closed 4 months ago

phaedon commented 7 months ago

This is a first step to support the changes outlined in https://blog.bazel.build/2023/07/24/whats-new-with-bzlmod.html

rwgk commented 7 months ago

LGTM — But I don't have a lot of relevant background.

@laramiel could you please confirm?

I'll need to import this change manually. (The source of truth for this repo is the Google-internal SCM system.) This change will then get auto-exported from there.

phaedon commented 6 months ago

Is this PR making its way through the system? Once it's there, we should consider adding a versioned release so that we can add this library to the BCR (https://registry.bazel.build/)

rwgk commented 6 months ago

Just to make a connection that may be relevant (not sure): pybind/pybind11_bazel#72

@junyer for awareness.

junyer commented 6 months ago

Supporting Bzlmod is on @david-crouse's radar. :D

phaedon commented 4 months ago

This is resolved thanks to https://github.com/pybind/pybind11_protobuf/commit/b4a2e87a10cd5f6309e4ff67c040a470d7ec2373