search

pybind / pybind11_protobuf

Pybind11 bindings for Google's Protocol Buffers
Other
54 stars 33 forks source link

Strip out code that depends on `PyProto_API` when exporting from Google codebase to GitHub. #165

Closed copybara-service[bot] closed 2 months ago

copybara-service[bot] commented 2 months ago

Strip out code that depends on PyProto_API when exporting from Google codebase to GitHub.

For context see https://github.com/pybind/pybind11_protobuf/pull/161, in particular https://github.com/pybind/pybind11_protobuf/pull/161#issuecomment-2176991293.

Intentionally not stripping out the check_unknown_fields.h,cc sources:

  1. For simplicity, and

  2. so that it is more obvious externally what the corresponding code in pybind11_protobuf/tests/extension_test.py is about (stripping out the test code would lead to distracting clutter).

rwgk commented 2 months ago

@StefanBruens What I have at the moment passes project-level testing Google-internally, and GitHub testing here. I still have to run Google-internal global testing. That'll take 12+ hours probably. Then I need to get the changes reviewed internally.

If you get a chance to test this PR for your purposes in the meantime, that would be great.

Note that I did not adopt the CMakeLists.txt SHARED to STATIC changes in this PR. I believe it'll be best to make those changes separately, even if it's only a tiny PR.