pybitcash / bitcash

BitCash: Python Bitcoin Cash Library (fork of ofek's Bit)
https://bitcash.dev
MIT License
97 stars 39 forks source link

Add support for Cashaddress URI #112

Closed yashasvi-ranawat closed 1 year ago

yashasvi-ranawat commented 2 years ago

Adds support for parsing and generating CashAddress URIs.

yashasvi-ranawat commented 1 year ago

I simplified the uri parsing and generation, uses urllib which makes it quite robust.

I added some simple documentation in dev guides. Is there any other place the documentation should be added?

PS: This also adds the cashaddress class Address, although that doesn't have any docs. I think I'd leave it at that, and wait for cashtokens merge. Otherwise the rebase will be quite messy.

merc1er commented 1 year ago

I added some simple documentation in dev guides. Is there any other place the documentation should be added?

I think that should do. I will build the site and see if that's enough.

merc1er commented 1 year ago

Seems like there's only one mention of URI in the changelog:

cl

It should probably have its own short page with a couple examples, a bit like this: https://bitcash.dev/guide/keys.html#formats.

yashasvi-ranawat commented 1 year ago

It should probably have its own short page with a couple examples, a bit like this: https://bitcash.dev/guide/keys.html#formats.

I added CashAddr as a new page. It also describes the URI. How does that look?