Closed merc1er closed 3 years ago
Looking good but we're still a hair below 90%. Any way we can get over that or should we bump the target to 89%?
OK @teran-mckinney I added a couple more tests to bring coverage to exactly 90% for now 😅
We should probably focus on bringing that number even higher in a later PR.
Nice work!
The regtest tests were skipped as they require a local node and a Bitcoin.com type REST API to run locally. This decreases code coverage below 90%.
Instead of skipping them, I am flagging them in this PR with a
--regtest
marker. By default, the regtest tests are not run, but ifpython run_test.py --regtest
orpytest --regtest
is used, it will run them using default ports to connect to the local node.