search

pybites / challenges

PyBites Code Challenges
https://codechalleng.es/challenges/
692 stars 2.29k forks source link

PCC02 GeoffRiley #589

Closed GeoffRiley closed 5 years ago

GeoffRiley commented 5 years ago

Difficulty level (1-10): [4] Estimated time spent (hours): [3] Completed (yes/no): [Yes] I stretched my coding skills (if yes what did you learn?): [Manipulating dictionaries in different ways. ] Other feedback (what can we improve?): [I chose to use the game.py rather than game-help.py. After completing the task I looked at the other and found that I deviated from the pattern considerably… possibly detrimentally, I'm not sure.]

jcastle13 commented 5 years ago

Hello @GeoffRiley . Would it be possible to create the functions that are used in the test_game.py? This will help to validate the code when you run test_game.py. For example, the function: _drawletters was not able to be found in the game.py. Whenever you make changes to the code it is good practice to validate it through a testbench. In this case it is test_game.py. :)

GeoffRiley commented 5 years ago

Hi @jcastle13, the instructions are to not include the test script in with the pull… so I didn't.

However, now that I have pulled it back from my stack I can see that I was following the instructions to build the game rather than following the tests… I must have had some kind of brain storm. It is clear that this is why I saw that I had deviated from the pattern used by everyone else. I'll close this PR an rework it. Thank you for the heads up.