pybites / challenges

PyBites Code Challenges
https://codechalleng.es/challenges/
692 stars 2.29k forks source link

PCC01 Abdulkadir98 #627

Closed Abdulkadir98 closed 5 years ago

Abdulkadir98 commented 5 years ago

ATTENTION: before clicking "Create Pull Request" please submit some meta data, thanks!

Difficulty level (1-10): [2] Estimated time spent (hours): [1] Completed (yes/no): [yes] I stretched my coding skills (if yes what did you learn?): [file manipulation] Other feedback (what can we improve?): []

jcastle13 commented 5 years ago

Hello @Abdulkadir98,

Wanted to know why are you manipulating wordvalue.py file twice? You should only need to manipulate it within your own branch. The wordvalue.py file in '01' will be changed which isn't something we would want.

Abdulkadir98 commented 5 years ago

I was not aware of that, I'll create a new branch.

jcastle13 commented 5 years ago

Don’t think you need to create a new branch since you have one already. Just need to remove the file from 01/wordvalue.py

jcastle13 commented 5 years ago

Why did you close it?