search

pybites / challenges

PyBites Code Challenges
https://codechalleng.es/challenges/
693 stars 2.29k forks source link

PCC03 werefrog #636

Closed werefrog closed 4 years ago

werefrog commented 4 years ago

Difficulty level (1-10): [2] Estimated time spent (hours): [1] Completed (yes/no): [Yes] I stretched my coding skills (if yes what did you learn?): [I used SequenceMatcher for the first time. I also spent some time to think about "efficient" ways to pass an ordering key when sorting collections.] Other feedback (what can we improve?): []

jcastle13 commented 4 years ago

Hello @werefrog. Just curious, have you tried running your code under the test_tags.py? It looks like it is failing for the test_get_similarities test.

werefrog commented 4 years ago

Hello @jcastle13 . Thank you to pointing that mistake . Apparently I didn't test my last commit (using the tag argument ...). Lesson learned, sorry for that.

By the way, this one pass the tests ;)

jcastle13 commented 4 years ago

@werefrog Code looks great. :)