search

pybliometrics-dev / pybliometrics

Python-based API-Wrapper to access Scopus
https://pybliometrics.readthedocs.io/en/stable/
Other
410 stars 128 forks source link

Adding funding id in Funding object #210

Closed astrochun closed 2 years ago

astrochun commented 2 years ago

Feature request

This is in referenced to some discussions on #209. See: https://github.com/pybliometrics-dev/pybliometrics/issues/209#issuecomment-936501454

Adding the grant numbers as part of Funding class.

Michael-E-Rose commented 2 years ago

Thanks so much for this! I bump a new minor release in the next week or so

astrochun commented 2 years ago

Thanks so much for this! I bump a new minor release in the next week or so

Not sure what your method for release is, particularly with pypi publishing, but it can be automated with GitHub Actions. See: https://github.com/pypa/gh-action-pypi-publish. You just need a token with scope for pybliometrics.

Here's how I've deployed (example) via a git tag vX.Y.Z -a && git push --tags https://github.com/astrochun/github-stats-pages/blob/main/.github/workflows/pypi-publish.yml

If you can get the release out sooner, that would be much appreciated. I presume the versioning bump will be to "3.0.2"

Michael-E-Rose commented 2 years ago

I'll do this Saturday evening, just let me return from holidays. There's two more things I have on my list. I do tag the commits, but I don't use GitHub actions yet - will have a look!

astrochun commented 2 years ago

No worries. This is open source, after all. Your work on this is quite impactful. If I know the expected version I can just pin it in my requirements.txt.