search

pybliometrics-dev / pybliometrics

Python-based API-Wrapper to access Scopus
https://pybliometrics.readthedocs.io/en/stable/
Other
410 stars 128 forks source link

Add ORCiD ID in AbstractRetrieval #222

Closed astrochun closed 2 years ago

astrochun commented 2 years ago

Closes #217

Michael-E-Rose commented 2 years ago

I think the class' docstring is missing, isn't?

astrochun commented 2 years ago

I think the class' docstring is missing, isn't?

Yes, it seems so.

Michael-E-Rose commented 2 years ago

What I meant is to update the docstring for AbstractRetrieval().authorgroup: https://github.com/pybliometrics-dev/pybliometrics/blob/master/pybliometrics/scopus/abstract_retrieval.py#L51-L58

astrochun commented 2 years ago

What I meant is to update the docstring for AbstractRetrieval().authorgroup: https://github.com/pybliometrics-dev/pybliometrics/blob/master/pybliometrics/scopus/abstract_retrieval.py#L51-L58

Ah, you said class docstrings and that confused me. Thanks for clarifying. That should do it and I found a minor typo

astrochun commented 2 years ago

Unless I'm mistaken, there has not been a new PyPI release with this or #216. Is that correct?

Michael-E-Rose commented 2 years ago

I bumped 3.2.0 two days ago, see https://pybliometrics.readthedocs.io/en/stable/classes/AbstractRetrieval.html#pybliometrics.scopus.AbstractRetrieval.authorgroup

I guess you didn't see it because I didn't link you on twitter this time ;)

astrochun commented 2 years ago

I bumped 3.2.0 two days ago, see https://pybliometrics.readthedocs.io/en/stable/classes/AbstractRetrieval.html#pybliometrics.scopus.AbstractRetrieval.authorgroup

I guess you didn't see it because I didn't link you on twitter this time ;)

HAHA. It helps.