search

pybliometrics-dev / pybliometrics

Python-based API-Wrapper to access Scopus
https://pybliometrics.readthedocs.io/en/stable/
Other
407 stars 127 forks source link

Implements returning identified ISSNs on full view #290

Closed james-geiger closed 1 year ago

james-geiger commented 1 year ago

This PR addresses conversation in #52

  1. Added ISSN named tuple in the form of (issn, type) for values returned on the AbstractRetrieval class.
  2. Type returns None if the view is not 'FULL'
  3. Returns a list whether one or more
james-geiger commented 1 year ago

@Michael-E-Rose I've implemented this such that it will always return a list to prevent developers from having to check the returned type. It seems this is how a document with only one author would be handled as well.

Michael-E-Rose commented 1 year ago

Thanks, especially for remembering the tests!

Would you mind updating https://github.com/pybliometrics-dev/pybliometrics/blob/master/docs/classes/AbstractRetrieval.rst as well? I think the part that starts with "There are 52 attributes and 8 methods..." is the only one that needs change: Update the number and add the line for the ISSN property.