search

pyblish / pyblish-base

Pyblish base library - see https://github.com/pyblish/pyblish for details.
Other
127 stars 59 forks source link

fixed issue with plugins on windows platform #314

Open SegaMegaDrive16 opened 7 years ago

SegaMegaDrive16 commented 7 years ago

Plugins could`t be registered by register_plugins_path method

mottosso commented 7 years ago

Thanks @GreenGoseWithFunnyHat, are you able to provide an example I could use to reproduce this problem? I'll use that to create a test for it, so the problem is automatically caught the next time it appears.

SegaMegaDrive16 commented 7 years ago

I guess that windows plaform (tested on widnows 7 with different file editors) creates \r\n instead of \n on linux at the end of each string. ( I have found discussion about this, they say that MS-DOS chose CR+LF, and Windows inherited this. To catch this problem you need to test this on windows 7 platfrom ( i guess in 10th version it was fixed ) or replace '\n' to '\r\n' in you plugins file. If you need i can attach file with \r\n at the end of strings.

mottosso commented 7 years ago

Would it be possible to create a small sample, and upload it here? That way I can include this in the automated test suite.

mottosso commented 7 years ago

If you need i can attach file with \r\n at the end of strings.

Yes, please. :)

BigRoy commented 6 years ago

@GreenGoseWithFunnyHat have you been able to find some time to set up a reproducable example and maybe also implement a test that ensures it's safe with these commits?