Test for logging only pyblish records.

pyblish / pyblish-base

Pyblish base library - see https://github.com/pyblish/pyblish for details.

Other

127 stars 59 forks source link

Closed tokejepsen closed 7 years ago

tokejepsen commented 7 years ago

This is an effort to get pyblish to only record log records related to Pyblish. This means log calls with self.log.

tokejepsen commented 7 years ago

This is spawned from a discussion about non-ascii characters coming from other loggers; https://github.com/pyblish/pyblish-qml/issues/251

mottosso commented 7 years ago

Indeed, that catches the nail on the head. If we can make this test pass, it should resolve your ftrack issue as well.

tokejepsen commented 7 years ago

What about this solution?

Tests are passing, and I've also tested with Ftrack and it solves the issue there as well.

mottosso commented 7 years ago

That's.. ingenious. If you could let this run for a few days in production, I see no issue with it. Good job.

tokejepsen commented 7 years ago

This has been working flawlessly :)

mottosso commented 7 years ago

Good. :)

Patch-version up and merge when ready!

tokejepsen commented 7 years ago

Ready for a merge :) Can't merge myself.

mottosso commented 7 years ago

Thanks @tokejepsen!

tokejepsen commented 7 years ago

Guess it needs a release as well?

mottosso commented 7 years ago

All done!