convert tuple ctx.obj["plugin_paths"] to list before concatenation

[iLLiCiTiT]

• ctx.obj["plugin_paths"] may be tuple which cause issues when trying to concatenate with list
• this fix will always convert the ctx.obj["plugin_paths"] to list to avoid this issue

[tokejepsen]

When does this return a tuple?

Maybe we can get a test for this, to cement it for the future?

[iLLiCiTiT]

We actually didn't found out when/why it happens. Seems like it happens when pyblish is launched with cli in python 3 (but not sure). We're using these args: -pp {paths_to_plugins} and -d {data_info}

EDITED: and --publish-gui argument

[iLLiCiTiT]

Is possible to merge this?

[davidlatwe]

It seems that module click which responsible to parsing args was meant to parse multiple options as tuple, see here.

In doc it says Multiple Options is similarly to nargs, which configures Multi Value Options, and it stores values as a tuple.

Look at the code in .vendor.click.core in this line, if you replace tuple with list, the error we has encountered is gone.

[mottosso]

There we go. Once someone can confirm this solves the issue this is ready to merge. Now values are list regardless of whether they come from Pyblish or CLI.

[iLLiCiTiT]

I checked and TypeError: can only concatenate tuple (not "list") to tuple did not appear so I assume it works.

[davidlatwe]

Nice ! Can confirm it works !