search

pyblish / pyblish-qml

Pyblish QML frontend for Maya 2013+, Houdini 11+, Nuke 8+ and more
GNU Lesser General Public License v3.0
114 stars 44 forks source link

Qt.WindowStaysOnTopHint been overrided #252

Closed davidlatwe closed 7 years ago

davidlatwe commented 7 years ago

Hi. Since that pyblish-qml gui could not be any other windows's child window, so I thought at least it could be on top, and I found this.

# pyblish_qml/app.py
# ... line 146
        if os.name == "nt":
            # Work-around for window appearing behind
            # other windows upon being shown once hidden.
            previous_flags = window.flags()
            window.setFlags(previous_flags | QtCore.Qt.WindowStaysOnTopHint)
            window.setFlags(previous_flags)
# ...

Last line window.setFlags(previous_flags) override the WindowStaysOnTopHint flag, is this on purpose ?

Thanks ! btw, really grate work 👍 this is art, Mr. white

mottosso commented 7 years ago

Well spotted! Would you be interested in making a pull request for this?

mottosso commented 7 years ago

Or actually no! This is the intended look.

I should have made a better note of it, this is essentially a "hack" required under Windows in order to restore the Window. By first making it stay on top, and then removing it.

That is I think what I meant by that comment, but it isn't very clear. And we almost removed it! I'll improve that note, but still, well spotted!