pyblish / pyblish-qml

Pyblish QML frontend for Maya 2013+, Houdini 11+, Nuke 8+ and more
GNU Lesser General Public License v3.0
114 stars 44 forks source link

fix instance Warning state behavior in GUI #267

Closed davidlatwe closed 7 years ago

davidlatwe commented 7 years ago

Found that instance's warning state only take effect from the last plugin.


Thought this should not be a normal instance item log level behavior, I added persistWarning into item-model to keep the warning state for instance item, and reset warning state if that instance got error.


Simple test case I used

davidlatwe commented 7 years ago

Since QML doesn't count the warning amount, so keep it count them as passed.

mottosso commented 7 years ago

Well spotted!

davidlatwe commented 7 years ago

Can I also fix my last PR's pep8 issue ?

mottosso commented 7 years ago

Excellent, this looks good!

In the future, it'd be better to put a commit message that describes what the change does, rather than a series of versions. Think of each commit as a self-contained whole, something you might one day want to revert, or cherry-pick onto a different branch. And consider what it will look like in midst other commits, here.

For now, this is fine. Just a minor tweak for future PRs.

mottosso commented 7 years ago

Thanks @davidlatwe!

davidlatwe commented 7 years ago

In the future, it'd be better to put a commit message that describes what the change does

Sure, will do !