search

pyblish / pyblish-qml

Pyblish QML frontend for Maya 2013+, Houdini 11+, Nuke 8+ and more
GNU Lesser General Public License v3.0
114 stars 44 forks source link

Check icon #277

Closed mottosso closed 6 years ago

mottosso commented 6 years ago

Along the theme of section colors, I wanted to see what it'd look like to update the checkbox icon with something other than the check, as check normally means "all good", which isn't the case when things error.

untitled project

Not sure it's an improvement.. Welcome to tinker.

As I was writing this, I discovered a minor bug in the previously merged PR; namely that the section icon went too dark when unexpanded and had no status.

untitled project

tokejepsen commented 6 years ago

That is an interesting idea!

Could we maybe remove the box around the exclamation icon? And how about the deprecation icon for warnings?

BigRoy commented 6 years ago

Not sure if it's better - I think it's more clutter.

How about after processing that the checkboxes turn "fully colored" instead of showing an icon - they would just be red, orange or green. And can't be toggled.

tokejepsen commented 6 years ago

How about after processing that the checkboxes turn "fully colored" instead of showing an icon

+1

tokejepsen commented 6 years ago

Here are the solid colors in action:

dec 18 2017 11_09 am

Its in a PR for @mottosso fork; https://github.com/mottosso/pyblish-qml/pull/3

mottosso commented 6 years ago

Oh wow, that looks great. Merging that.

tokejepsen commented 6 years ago

I have another PR which just cleans the added code and versions up, ready for a merge; https://github.com/mottosso/pyblish-qml/pull/4

mottosso commented 6 years ago

Thanks @tokejepsen, happy to merge this. Any last comments?

tokejepsen commented 6 years ago

I'm good for a merge :) @BigRoy ?

BigRoy commented 6 years ago

Looks awesome visually. Great work.