search

pyblish / pyblish-qml

Pyblish QML frontend for Maya 2013+, Houdini 11+, Nuke 8+ and more
GNU Lesser General Public License v3.0
114 stars 44 forks source link

Minor fix: eventFilter drop on minimized; comments lost sync after GUI rest #299

Closed davidlatwe closed 6 years ago

davidlatwe commented 6 years ago

This PR will provide two fix:

  1. eventFilter get removed when main window minimized.

    did not found this bug on previous PR, sorry :(

  2. Comment did not restore back to host after rest, here's the scenario:
    1. Artists input comments to QML comment box
    2. Validation failed or some other cases that make artist to press reset botton
    3. Comments remain in QML comment box and did not make any new input
    4. Published, but the comment did not collect to database
mottosso commented 6 years ago

Thanks @davidlatwe, once you're happy, you're welcome to merge. (I've added you to the contributor list!)

davidlatwe commented 6 years ago

Much appreciated ! Merge will be made right after I got back to my workplace and bump the version. Thanks again @mottosso :)

davidlatwe commented 6 years ago

Sorry for the spamming, didn't know that git rebase will break GitHub code review link, so I did a reset and re-bump the version with conflict resolved.

Merging now :)

mottosso commented 6 years ago

Thanks @davidlatwe :)