search

pyblish / pyblish-qml

Pyblish QML frontend for Maya 2013+, Houdini 11+, Nuke 8+ and more
GNU Lesser General Public License v3.0
114 stars 44 forks source link

Fix state machine transition bug from PR #304 #306

Closed davidlatwe closed 6 years ago

davidlatwe commented 6 years ago

In the state machine, extracting state needs to transition to finished if the validation failed during the publish, or the stop button won't change to reset button, and cause user operation not able to continue.

qml_fix304_before

This commit fixed that.

qml_fix304_after

Somehow I missed this one in the previous tests, after founding this bug in my work, right after the release of 1.8.6, I spend a day did a series of user operation flow inspection, including each kind of Action, and compared the outcome with previous releases, so far this is the only one that I have missed based on previous PRs.

mottosso commented 6 years ago

Fantastic work @davidlatwe, you are welcome to merge!

davidlatwe commented 6 years ago

Thanks, merging ! :heart: