Toggling family groups does not respect mandatory Instances

pyblish / pyblish-qml

Pyblish QML frontend for Maya 2013+, Houdini 11+, Nuke 8+ and more

GNU Lesser General Public License v3.0

114 stars 44 forks source link

Toggling family groups does not respect mandatory Instances #309

Closed darkvertex closed 5 years ago

darkvertex commented 6 years ago

I discovered that the feature introduced by #281 does not respect whether any of the instances in that group have .data['optional'] set to False, ie "mandatory" or "non-optional" instances, which I had introduced support for as of version 1.7.4.

Toggling should not fail, but it should skip the non-optional Instances from being toggled.

mottosso commented 6 years ago

Thanks for reporting this @darkvertex

davidlatwe commented 5 years ago

I have got this solved on my end, will make a PR after the version 1.9.0 is out !

darkvertex commented 5 years ago

Thanks for fixing this, @davidlatwe! :tada: