Fix 309 - Githubissues

pyblish / pyblish-qml

Pyblish QML frontend for Maya 2013+, Houdini 11+, Nuke 8+ and more

GNU Lesser General Public License v3.0

114 stars 44 forks source link

Fix 309 #314

Closed davidlatwe closed 5 years ago

davidlatwe commented 5 years ago

This PR will fix #309 , and UX bug related to #281 but on plugin section.

Before

qml_309

The instance Batman and David should not be toggled, but the restriction got bypassed via toggling the section.
Plugin checkbox did not give immediate respond to section toggling.

After

qml_309fix

All fixed !

Implementation

Collect all optional items' state.
Override section state if all optional items are in the same state. This guaranteed the optional item be able to respond to every toggle.
Set check state.

mottosso commented 5 years ago

Nice work! Could you increment the version too? Then I'll make a new release for it.

davidlatwe commented 5 years ago

Done !

BigRoy commented 5 years ago

Good stuff again David! :+1:

tokejepsen commented 5 years ago

Awesome work @davidlatwe

davidlatwe commented 5 years ago

Thanks :) Merging this, and pinging @mottosso for release :P

mottosso commented 5 years ago

Yes, that is all fine! :)

One question though, that I noticed elsewhere as well, how come the instances are green, and yet checkable? :O I thought they were green only after having been processed, at which point they would not be checkable anymore?

mottosso commented 5 years ago

Oh and I remembered you are able to make releases too, you are most welcome to do that here as well!

davidlatwe commented 5 years ago

how come the instances are green, and yet checkable?

The reason it's green is that there's a plugin printing log message for every instances in collecting phase.

class ListHeros(pyblish.api.InstancePlugin):
    order = pyblish.api.CollectorOrder + 0.1

    def process(self, instance):
        self.log.info(instance)

So yeah, they did been processed :)

at which point they would not be checkable anymore?

I intentionally set data["optional"] = False to some instances at their creation, for the example ;D

Oh and I remembered you are able to make releases too

Haha, thanks :D

BigRoy commented 5 years ago

One question though, that I noticed elsewhere as well, how come the instances are green, and yet checkable? :O I thought they were green only after having been processed, at which point they would not be checkable anymore?

AND

The reason it's green is that there's a plugin printing log message for every instances in collecting phase.