search

pybop-team / PyBOP

A parameterisation and optimisation package for battery models.
https://pybop-docs.readthedocs.io
BSD 3-Clause "New" or "Revised" License
61 stars 17 forks source link

[Bug]: Github pybop.CMAES tests are failing due to np.inf cost return #102

Closed BradyPlanden closed 10 months ago

BradyPlanden commented 10 months ago

Python Version

3.8-3.11

Describe the bug

Failing tests here: https://github.com/pybop-team/PyBOP/actions/runs/6895515377/job/18759625531

Seperate from #98. I can't repeat the test fails locally (Intel Mac, AMD Ubuntu), but I suspect it's from the new optimiser options here:https://github.com/pybop-team/PyBOP/blob/2c7e74495425ba801aeb2b09670b55fa405465f3/tests/unit/test_parameterisations.py#L119.

Steps to reproduce the behaviour

n/a

Relevant log output

No response

BradyPlanden commented 10 months ago

To solve the random failure of CMAES, I think we need to pass a representation of pints.RectangularBoundaries to CMAES. See here.