pybop-team / PyBOP

A parameterisation and optimisation package for battery models.

https://pybop-docs.readthedocs.io

BSD 3-Clause "New" or "Revised" License

66 stars 20 forks source link

[Bug]: Fix Integration tests post #304 #320

Closed BradyPlanden closed 5 months ago

BradyPlanden commented 5 months ago

Python Version

N/A

Describe the bug

304 has reduced the test suite completion time, but has resulted in a higher failure rate of the integration tests. A fix is available in #319 and will be duplicated into this branch to expedite the fix.

Steps to reproduce the behaviour

See: https://github.com/pybop-team/PyBOP/actions/runs/9019436453/job/24782313287

Relevant log output

No response

NicolaCourtier commented 5 months ago

I also saw this when I merged develop into #236, changing the scale in line 15 in tests/integration/test_parameterisations.py seems to help. I reduced it from 0.05 to 0.03 in that PR.

BradyPlanden commented 5 months ago

Thanks @NicolaCourtier. I've opened a PR for this fix now. I was able to fix this issue without changing the range of potential parameter values. This was achieveable without extending the synthetic prediction, but the extension should help with identifiability of the fitting parameters in this case.

It should be ready for review soon, I want to run the scheduled workflow on the branch for confirmation. On initial testing, this change appears to allow for tighter assertions on the parameterisations test, which would be great.