search

pybop-team / PyBOP

A parameterisation and optimisation package for battery models.
https://pybop-docs.readthedocs.io
BSD 3-Clause "New" or "Revised" License
54 stars 13 forks source link

[Bug]: Release action fails on soft-prop #401

Open BradyPlanden opened 2 months ago

BradyPlanden commented 2 months ago

Python Version

3.11

Describe the bug

The release action is failing during the signing and uploading of the built wheels due to a soft-prop issue: https://github.com/pybop-team/PyBOP/actions/runs/9839631010

The generated error is for soft-prop@v1, however, v2 is defined in the action and approved on the repository. @agriyakhetarpal, do you mind taking a look at this one?

Steps to reproduce the behaviour

See v24.6 release action: https://github.com/pybop-team/PyBOP/actions/runs/9839631010

Relevant log output

No response

agriyakhetarpal commented 1 month ago

Strange, I think this was either a GitHub error or that one of the actions is a composite action that uses v1 internally. Should we allow the use of external actions? If and as long as we make approvals required workflow runs for any outside collaborators, that should limit the use of actions as well.