pybop-team / PyBOP

A parameterisation and optimisation package for battery models.
https://pybop-docs.readthedocs.io
BSD 3-Clause "New" or "Revised" License
54 stars 13 forks source link

Add Thermal Thevenin Example (Remove Params from Others) #437

Open BradyPlanden opened 1 month ago

BradyPlanden commented 1 month ago

This issue is to remove the thermal parameters from non-thermal Thevenin examples: https://github.com/pybop-team/PyBOP/blob/9e15f90b75c4f5fb04cb17c0807dd0b5e1a2e6fb/examples/scripts/ecm_CMAES.py#L24

At the sametime, let's add a Thevenin with thermal submodel example with those corresponding parameters. For more information on PyBaMM's thermal submodel see: https://docs.pybamm.org/en/latest/source/examples/notebooks/models/thermal-models.html

BradyPlanden commented 1 month ago

@Dibyendu-IITKGP, are you be able to take this one on?

Dibyendu-IITKGP commented 1 month ago

Not yet. I'll do it.