search

pybop-team / PyBOP

A parameterisation and optimisation package for battery models.
https://pybop-docs.readthedocs.io
BSD 3-Clause "New" or "Revised" License
66 stars 20 forks source link

Add applied current functionality to EIS methods #478

Open BradyPlanden opened 2 months ago

BradyPlanden commented 2 months ago

Feature description

First discussed in #417, this issue is to add applied current functionality to the EIS forward model.

Motivation

The ability to incorporate applied current in the frequency domain impedance predictions enables non-stationary EIS methods for improvements in parameter inference.

Possible implementation

No response

Additional context

No response

rtimms commented 2 months ago

I don't have the full context here, but is the forward simulation part of this something that can live in the EIS package? I'm conscious that integrating code directly in PyBOP and also developing pybamm-eis might lead to duplicated work or incompatibilities down the line.

BradyPlanden commented 2 months ago

Hi @rtimms, I generally agree. This issue can probably be moved to pbeis, with PyBOP implementing the changes afterwards. Due to the way we build the forward model, I think we would need to refactor the underlying BaseModel to work directly with pbeis. Alternatively, we could look at building pbeis so that the API can be used by both PyBOP and casual users. At the moment I've implemented the pbeis method directly into PyBOP's BaseModel class, but in the future this could be rethought and updated.

rtimms commented 2 months ago

We could also just put the EISSimulation straight into pybamm and get rid of pbeis. Not sure of the the way PyBOP uses the model and sim, but having the EIS in pybamm would simplify things and avoid conflicts.