Open Dibyendu-IITKGP opened 1 month ago
@BradyPlanden I think with this example, we can remove previously added equivalent_circuit_identification_hppc.ipynb
and equivalent_circuit_identification_multipulse.ipynb
files. This file serves all the purposes of the mentioned files. Also, I think I can add within the same file how to use cellpy (as an alternative to Battery-Data-Toolkit) for reading cycler data. Let me know your thoughts.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.05%. Comparing base (
46ae507
) to head (5c6c8a2
). Report is 10 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
A example notebook file is added to demonstrate how to import battery cycler data directly to PyBOP without any pre-processing. Battery-Data-Toolkit is used for this purpose. However, a similar kind of approach can be followed for any battery cycler data converter (example: cellpy etc.). It is also shown how to use part of the cycler data to fit HPPC pulses and estimate equivalent circuit parameters.
Issue reference
Fixes #504
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.