pybop-team / PyBOP

A parameterisation and optimisation package for battery models.
https://pybop-docs.readthedocs.io
BSD 3-Clause "New" or "Revised" License
73 stars 22 forks source link

Allow different lengths for validation plots #538

Closed NicolaCourtier closed 1 month ago

NicolaCourtier commented 1 month ago

Description

The function plot.quick is useful for validation but fails to produce a figure when the target and model outputs have different lengths. This update disables the computation of the standard deviation which allows the target and model to be plotted regardless of length.

Issue reference

Fixes # (issue-number)

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

Type of change

Key checklist:

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

Thank you for contributing to our project! Your efforts help us to deliver great software.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.09%. Comparing base (c8b00e6) to head (28ac412). Report is 6 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #538 +/- ## =========================================== + Coverage 99.08% 99.09% +0.01% =========================================== Files 52 54 +2 Lines 3605 3764 +159 =========================================== + Hits 3572 3730 +158 - Misses 33 34 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.