pybop-team / PyBOP

A parameterisation and optimisation package for battery models.
https://pybop-docs.readthedocs.io
BSD 3-Clause "New" or "Revised" License
73 stars 22 forks source link

Adds ScaledLogLikelihood Class #541

Closed BradyPlanden closed 3 weeks ago

BradyPlanden commented 3 weeks ago

Description

Adds a ScaledLogLikelihood class, alongside a base meta likelihood class to reduce code duplication.

Issue reference

Fixes #540

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

Type of change

Key checklist:

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

Thank you for contributing to our project! Your efforts help us to deliver great software.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.12%. Comparing base (c8b00e6) to head (61a26d7). Report is 9 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #541 +/- ## =========================================== + Coverage 99.08% 99.12% +0.03% =========================================== Files 52 55 +3 Lines 3605 3869 +264 =========================================== + Hits 3572 3835 +263 - Misses 33 34 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.